Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12719#discussion_r62789853
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -650,15 +646,15 @@ object FoldablePropagation extends Rule[LogicalPlan] {
if (foldableExprSet.isEmpty) {
plan
- } else if (hasCommandOrUnion(plan)) {
- replaceInSubplan(plan)
} else {
val foldableMap =
AttributeMap(foldableExprSet.toSeq.map(_.asInstanceOf[Alias])
.map(a => (a.toAttribute, a.child)))
- CleanupAliases(plan.transformAllExpressions {
- case a : AttributeReference if foldableMap.contains(a) =>
- Alias(foldableMap.getOrElse(a.toAttribute, a), a.name)()
+ CleanupAliases(plan.transformUp {
+ case p: LogicalPlan if !hasCommandOrUnion(p) =>
p.transformAllExpressions {
+ case a: AttributeReference if foldableMap.contains(a) =>
+ Alias(foldableMap.getOrElse(a.toAttribute, a), a.name)()
+ }
--- End diff --
As you told me, for the `stop` flag, I can change the above code more like
the following. IMHO, the above code is simpler. The query optimization speed is
more important? If then, I'll update that too.
```
var stop = false
CleanupAliases(plan.transformUp {
case p: LogicalPlan if !stop && hasCommandOrUnion(p) =>â¨
stop = true
p
case p: LogicalPlan if !stop && !hasCommandOrUnion(p) =>
p.transformAllExpressions {
case a: AttributeReference if foldableMap.contains(a) =>â¨
Alias(foldableMap.getOrElse(a.toAttribute, a), a.name)()â¨
}
})
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
