Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13042#discussion_r62799170 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/JavaUtils.java --- @@ -109,6 +128,27 @@ public static void deleteRecursively(File file) throws IOException { } } + private static void deleteRecursivelyForUnix(File file) throws IOException { + Process process = null; + final ProcessBuilder builder = new ProcessBuilder("rm", "-rf", file.getAbsolutePath()); + + try { + process = builder.start(); + process.waitFor(); + if (process.exitValue() == 0 && !file.exists()) { --- End diff -- Invert this logic? if this isn't true, throw
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org