Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12943#discussion_r62925960
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -75,8 +75,8 @@ private[ml] trait MultilayerPerceptronParams extends
PredictorParams
* @group expertParam
*/
final val solver: Param[String] = new Param[String](this, "solver",
- " Allows setting the solver: minibatch gradient descent (gd) or
l-bfgs. " +
- " l-bfgs is the default one.",
+ "Allows setting the solver: minibatch gradient descent (gd) or l-bfgs.
" +
+ "(Default l-bfgs)",
--- End diff --
So you mentioned something similar in another PR - but this seems to be the
standard we follow (both in the file and others) for multi line strings with +
which is add 2 for original indent for multi-line and then add two for +
indent. I'm not saying this a good style - but it does seem to be the one we
follow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
