Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13008#discussion_r62964694
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -505,7 +505,7 @@ class DatasetSuite extends QueryTest with
SharedSQLContext {
val schema = StructType(Seq(
StructField("f", StructType(Seq(
StructField("a", StringType, nullable = true),
- StructField("b", IntegerType, nullable = false)
+ StructField("b", IntegerType, nullable = true)
--- End diff --
With the new null check, we will trigger error earlier than this test
expected. This test is testing the `AssertNotNull` expression, which is used
for converting nullable column to not-nullable object field(like primitive int).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
