Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13048#discussion_r63133864
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive.orc
+
+import org.apache.hadoop.conf.Configuration
+
+/**
+ * Options for the ORC data source.
+ */
+private[orc] class OrcOptions(
+ @transient private val parameters: Map[String, String],
+ @transient private val conf: Configuration)
+ extends Serializable {
+
+ import OrcOptions._
+
+ /**
+ * Compression codec to use. By default use the value specified in
Hadoop configuration.
+ * Acceptable values are defined in [[shortOrcCompressionCodecNames]].
+ */
+ val compressionCodec: String = {
+ val default = conf.get(ORC_COMPRESSION, "SNAPPY")
--- End diff --
i think overtime it'd be better if we are switching entirely over to
Spark's own configuration, and propagate values over to Hadoop Configuration,
not the other way around ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
