Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13057#discussion_r63155573
  
    --- Diff: 
launcher/src/main/java/org/apache/spark/launcher/CommandBuilderUtils.java ---
    @@ -334,6 +334,18 @@ static void addPermGenSizeOpt(List<String> cmd) {
       }
     
       /**
    +   * Gets the OutOfMemoryError option for Spark if the user hasn't set it.
    +   */
    +  public static String getOutOfMemoryErrorArgument(List<String> cmd) {
    --- End diff --
    
    I don't see that? the only similar method I see manages `-XX:MaxPermGen` 
and it does not work this way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to