Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/13042#issuecomment-219208629
This seems OK to me. There is actually another delete-recursively method in
TestShuffleDataContext in network-shuffle which should be able to use this
method rather than define it again.
It seems like this could be usefully implemented in the main
`Utils.deleteRecursively` as well, rather than have two differing
implementations. I'm trying to figure out whether that's a win or poses any
risks; it probably speeds up some big deletes but does mean spawning a process,
in many cases at JVM shutdown.
If anyone's supportive of that we could try it here, but it's not essential
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
