Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/12889#discussion_r63323247 --- Diff: python/pyspark/ml/regression.py --- @@ -708,7 +710,7 @@ def _create_model(self, java_model): @inherit_doc -class DecisionTreeModel(JavaModel): +class DecisionTreeModel(JavaModel, JavaPredictionModel): --- End diff -- That seems reasonable, I've got some less direct code things I need to catch up on for the next few days, but if no one picks up the regression stuff in the meantime I'll roll that into this PR.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org