Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/13129#discussion_r63332619
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -159,9 +159,7 @@ class LinearRegression @Since("1.3.0") (@Since("1.3.0")
override val uid: String
override protected def train(dataset: Dataset[_]): LinearRegressionModel
= {
// Extract the number of features before deciding optimization solver.
- val numFeatures = dataset.select(col($(featuresCol))).limit(1).rdd.map
{
- case Row(features: Vector) => features.size
- }.first()
+ val numFeatures =
dataset.select(col($(featuresCol))).first().getAs[Vector](0).size
--- End diff --
same here, can we do `as[Vector]` instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
