Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13061#discussion_r63400095
  
    --- Diff: build/spark-build-info ---
    @@ -0,0 +1,30 @@
    +#!/usr/bin/env bash
    +
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#    http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +#
    +
    +# This script generates the build info for spark and places it into the 
spark-version-info.properties file.
    +# Arguments:
    +#   build_tgt_directory - The target directory where properties file would 
be created. [./core/target/extra-resources]
    +#   spark_version - The current version of spark
    +
    +RESOURCE_DIR=$1
    +mkdir -p $RESOURCE_DIR
    +SPARK_BUILD_INFO=${RESOURCE_DIR}/spark-version-info.properties
    +
    +(echo version=$2; echo user=$USER; echo revision=$(git rev-parse HEAD); 
echo branch=$(git rev-parse --abbrev-ref HEAD);
    --- End diff --
    
    Can you put this in a separate function instead?
    
    ```
    echo_properties() {
      echo foo
      echo bar
      echo foobar
    }
    
    echo_properties > "$SPARK_BUILD_INFO"
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to