Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13127#discussion_r63438911
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -208,7 +286,7 @@ private[client] class Shim_v0_12 extends Shim with
Logging {
predicates: Seq[Expression]): Seq[Partition] = {
// getPartitionsByFilter() doesn't support binary comparison ops in
Hive 0.12.
// See HIVE-4888.
- logDebug("Hive 0.12 doesn't support predicate pushdown to metastore. "
+
+ logWarning("Hive 0.12 doesn't support predicate pushdown to metastore.
" +
--- End diff --
For this method , it is allowed to have false positives. Let's update the
doc of this method. Also, let's revert this change (just to avoid of letting
users think that this warning indicates an error).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
