Github user akohli commented on the pull request:

    https://github.com/apache/spark/pull/13130#issuecomment-219750370
  
    curious on a couple of things, firstly, you are using CacheBuilder with a 
cache size of 1000, is that sufficient?  Wouldn't it be better to catch an 
exception or detect an error when a jobconf is added to the original map; 
alternatively is this masking an issue that proper GC is not happening for 
unreferenced cached configs?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to