Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13147#discussion_r63567867
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/ExperimentalMethods.scala ---
    @@ -42,7 +43,7 @@ class ExperimentalMethods private[sql]() {
        * @since 1.3.0
        */
       @Experimental
    -  @volatile var extraStrategies: Seq[Strategy] = Nil
    +  @volatile var extraStrategies: Seq[SparkPlanner => Strategy] = Nil
    --- End diff --
    
    I'm not sure if we want to change this interface and this feels a little 
hacky to me.  It seems like `planLater` might actually be the problem.  In an 
earlier prototype we actually use a node that indicated "planLater" and looped 
it back through the planner instead of doing it all eagerly.  This let us do 
plan space exploration, but I'd have to spend some time thinking about how 
exactly that could work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to