Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13152#discussion_r63636132
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerId.scala
---
@@ -103,8 +121,11 @@ private[spark] object BlockManagerId {
* @param port Port of the block manager.
* @return A new [[org.apache.spark.storage.BlockManagerId]].
*/
- def apply(execId: String, host: String, port: Int): BlockManagerId =
- getCachedBlockManagerId(new BlockManagerId(execId, host, port))
+ def apply(execId: String,
+ host: String,
+ port: Int,
+ topologyInfo: Option[String] = None): BlockManagerId =
--- End diff --
Maybe we need to correct indentation as below..
```scala
def apply(execId: String,
host: String,
port: Int,
topologyInfo: Option[String] = None): BlockManagerId =
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
