Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13095#discussion_r63715298
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParserUtils.scala
---
@@ -43,6 +44,14 @@ object ParserUtils {
new ParseException(s"Operation not allowed: $message", ctx)
}
+ /** Check if duplicate keys exist in a set of key-value pairs. */
+ def checkDuplicateKeys(
+ keyPairs: mutable.Buffer[_ <: (String, Any)], ctx:
ParserRuleContext): Unit = {
--- End diff --
Style: Parameter per line.
`mutable.Buffer[_ <: (String, Any)]` is it possible to just check a `Seq`
or `Traversable`? Do you think it is possible to improve the signature (maybe
move the type of Any into a generic type)? It is kinda messy now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
