Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13177#discussion_r63809772
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
    @@ -480,7 +480,7 @@ private[client] class Shim_v0_13 extends Shim_v0_12 {
         try {
           Option(hive.getFunction(db, name)).map(fromHiveFunction)
         } catch {
    -      case CausedBy(ex: NoSuchObjectException) if 
ex.getMessage.contains(name) =>
    +      case CausedBy(ex: Exception) if ex.getMessage.contains(s"$name does 
not exist") =>
    --- End diff --
    
    Hm.. I am not familiar with this part though.. Would this be safe to catch 
all the exceptions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to