Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12979#discussion_r63916719 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -706,6 +711,60 @@ class CodegenContext { if (doSubexpressionElimination) subexpressionElimination(expressions) expressions.map(e => e.genCode(this)) } + + /** + * get a map of the pair of a place holder and a corresponding comment + */ + def getPlaceHolderToComments(): collection.Map[String, String] = { + placeHolderToComments + } + + /** + * Returns the string representation of this expression that is safe to be put in + * code comments of generated code. The length is capped at 128 characters. + */ + private[this] def toCommentSafeString(str: String): String = { --- End diff -- This is only used by CodeFormatter, I'd like to move it there.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org