Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13156#discussion_r63937901
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala ---
    @@ -163,6 +163,9 @@ private[sql] class SessionState(sparkSession: 
SparkSession) {
       def executePlan(plan: LogicalPlan): QueryExecution = new 
QueryExecution(sparkSession, plan)
     
       def refreshTable(tableName: String): Unit = {
    +    // Different from SparkSession.catalog.refreshTable, this API only 
refreshes the metadata.
    +    // It does not reload the cached data. That means, if this table is 
cached as
    +    // an InMemoryRelation, we do not refresh the cached data.
    --- End diff --
    
    this is super confusing, the fact that `spark.catalog.refreshTable` and 
`spark.sessionState.refreshTable` do different things. Should we just rename 
this to `invalidateTable` along with `HiveMetastoreCatalog.refreshTable`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to