GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/13205
[SPARK-15421][SQL] Validate DDL property values
## What changes were proposed in this pull request?
When we parse DDLs involving table or database properties, we need to
validate the values.
E.g. if we alter a database's property without providing a value:
```
ALTER DATABASE my_db SET DBPROPERTIES('some_key')
```
Then we'll ignore it with Hive, but override the property with the
in-memory catalog. Inconsistencies like these arise because we don't validate
the property values.
In such cases, we should throw exceptions instead.
## How was this patch tested?
`DDLCommandSuite`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewor14/spark ddl-prop-values
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13205.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13205
----
commit a61b2608ed9b9f61e1ac194c38c70cdfb61ad7e6
Author: Andrew Or <and...@databricks.com>
Date: 2016-05-19T22:08:20Z
Validate table and database properties
commit 3920d2a84fc1f9c5bca60a1dad265aca4f345413
Author: Andrew Or <and...@databricks.com>
Date: 2016-05-19T22:29:56Z
Add tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
