Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13163#discussion_r63972414
--- Diff:
launcher/src/test/java/org/apache/spark/launcher/SparkSubmitCommandBuilderSuite.java
---
@@ -59,6 +59,18 @@ public void testClusterCmdBuilder() throws Exception {
}
@Test
+ public void testCliHelpAndNoArg() throws Exception {
+ List<String> sparkSubmitArgs = Arrays.asList(parser.HELP);
+ Map<String, String> env = new HashMap<>();
+ List<String> cmd = buildCommand(sparkSubmitArgs, env);
+ assertTrue("--help should be contained in the final cmd.",
cmd.contains(parser.HELP));
+
+ List<String> sparkEmptyArgs = Arrays.asList("");
+ cmd = buildCommand(sparkSubmitArgs, env);
--- End diff --
Oh, and BTW, you should use `Collections.emptyList()`, because you don't
really have an empty args list, but an args list with a single argument that
happens to be an empty string.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
