Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-220528702
I checked the source code of system2. Since a batch file with .cmd
extension is to be launched on Windows, I think it is more formal to use
shell() instead of system2(). Refer to
http://www.astrostatistics.psu.edu/datasets/R/html/base/html/shell.html. The
proposed fix is like follows:
```
if (.Platform$OS.type == "windows") {
shell(sparkSubmitBin, translate = TRUE, ...)
} else {
system2(sparkSubmitBin, ...)
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
