Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/13176#discussion_r64001546 --- Diff: docs/ml-features.md --- @@ -1064,7 +1069,8 @@ categorical features. The bin ranges are chosen by taking a sample of the data and dividing it into roughly equal parts. The lower and upper bin bounds will be `-Infinity` and `+Infinity`, covering all real values. This attempts to find `numBuckets` partitions based on a sample of the given input data, but it may -find fewer depending on the data sample values. +find fewer depending on the data sample values. Relative precision of the approxQuantile is set using --- End diff -- We should clarify that the quantile computation is approximate, perhaps borrowing from the `approxQuantile` docs, and provide a link to the API doc for the function.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org