Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1790#discussion_r15828193
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -246,22 +246,24 @@ class Word2Vec(
}
val newSentences = sentences.repartition(parallelism).cache()
+ val seed = 5875483L
--- End diff --
This does more than fix the seed for unit tests, but for every call. Is it
not a bit better to make the RNG injectable via a discreet package-private
setter and let the tests inject a seeded RNG?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
