Github user njwhite commented on the pull request:
https://github.com/apache/spark/pull/12951#issuecomment-220555299
Thanks for the review @squito - I've commented on the JIRA about why this
feature would be useful. As for the implementation - maybe "maxShare" is the
wrong word, as the change doesn't relate to the fair scheduler at all. Instead
it limits the maximum number of tasks a `Schedulable` can have running at any
one time. It really is just a one line change - `resourceOffer` now won't
accept any more resources (i.e. won't run any of its tasks) if the calculated
current value of `maxShares` means there isn't any free space in the pool. The
`maxShares` method just returns the maximum number of tasks allowed in the
pool, minus the number of tasks running in the pool. You can see the
propagation of the `maxShares` limit in the assertions I added to the
`PoolSuite` test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
