GitHub user MLnick opened a pull request:
https://github.com/apache/spark/pull/13228
[SPARK-15442][ML][PYSPARK] Add 'relativeError' param to PySpark
QuantileDiscretizer
This PR adds the `relativeError` param to PySpark's `QuantileDiscretizer`
to match Scala.
Also cleaned up a duplication of `numBuckets` where the param is both a
class and instance attribute (I removed the instance attr to match the style of
params throughout `ml`).
Finally, cleaned up the docs for `QuantileDiscretizer` to reflect that it
now uses `approxQuantile`.
## How was this patch tested?
A little doctest and built API docs locally to check HTML doc generation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MLnick/spark SPARK-15442-py-relerror-param
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13228.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13228
----
commit 907123b8c13b6bd180821c8752e1e9d282a2a9fb
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-05-20T18:23:34Z
initial work
commit 60339055b11a57eeb25e93ba1429ca6022916609
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-05-20T19:47:26Z
clean up doc
commit 6417384f3b8a29dadea1089fdccb150a00cf26ad
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-05-20T19:57:51Z
amend doctest param value
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
