Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/13116#issuecomment-220857549
@burness that is no problem. I have taken a look at the current
implementation of the `RDD`'s `takeSample`; it is very similar to your
implementation. I do still think that implementation has problems, and I am not
sure we should add to the `Dataset`/`Dataframe` API.
You can always use the datasets 's RDD use its `takeSample` method, i.e.:
`spark.createDataset(dataset.rdd.takeSample(...))`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
