Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13236#discussion_r64157471
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -73,7 +74,7 @@ import org.apache.spark.util.{CircularBuffer, Utils}
private[hive] class HiveClientImpl(
override val version: HiveVersion,
sparkConf: SparkConf,
- hadoopConf: Configuration,
+ hadoopConf: Map[String, String],
--- End diff --
@rdblue FYI. I am changing the type from `Configuration` to `Map[String,
String]` because it is possible that Hadoop classes are not shared between
Spark side and the `IsolatedClientLoader` side. When Hadoop classes are not
shared, if we pass a `Configuration` object to `HiveClientImpl`, the class of
this `Configuration` object (this class is loaded by Spark's classloader) is
different from the `Configuration` class loaded by `IsolatedClientLoader`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
