Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13186#discussion_r64265705
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -543,6 +543,9 @@ public UTF8String repeat(int times) {
* @return the position of the first occurrence of substr, if not found,
-1 returned.
*/
public int indexOf(UTF8String v, int start) {
+ if (start < 0) {
+ return -1;
--- End diff --
actually this might not be OK. Normally `"abcd".indexOf("abc", -1)` gives
you 0, so we should follow that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
