Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13228#discussion_r64344703
  
    --- Diff: python/pyspark/ml/feature.py ---
    @@ -1250,6 +1257,20 @@ def getNumBuckets(self):
             """
             return self.getOrDefault(self.numBuckets)
     
    +    @since("2.0.0")
    +    def setRelativeError(self, value):
    +        """
    +        Sets the value of :py:attr:`relativeError`.
    +        """
    +        return self._set(relativeError=value)
    +
    +    @since("2.0.0")
    +    def getRelativeError(self):
    +        """
    +        Gets the value of relativeError or its default value.
    --- End diff --
    
    I think we should probably document the setters at some point, but perhaps 
2.1 timeframe.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to