Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/13266#issuecomment-221270507
I disagree that it's "too trivial to fix" for this specific case, because
(i) it actually makes the example code included in the ML User Guide
inconsistent with **all** other example code in the guide, and (ii) it doesn't
work if you try to copy-paste it into the spark-shell (these guide examples
should really work for that case). Also, no other User Guide example code (for
Scala) explicitly imports `DataFrame` - as you can see that import is not part
of the `include_example` section that goes into the User Guide (nor should it
be).
But it's a fair point to fix any other examples - `OneVsRestExample` is the
only other one I found that should be fixed up. There are others (such as the
"application" examples for random forest, linear regression etc), but they are
not in the user guide so it doesn't matter much for those.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
