Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1798#discussion_r15853902
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Algo.scala ---
@@ -27,4 +27,10 @@ import org.apache.spark.annotation.Experimental
object Algo extends Enumeration {
type Algo = Value
val Classification, Regression = Value
+
+ private[mllib] def stringToAlgo(name: String): Algo = name match {
--- End diff --
minor: `stringToAlgo` -> `fromString`? In the code, it might be more
natural to read
~~~
Algo.fromString("classification")
~~~
~~~
Algo.stringToAlgo("classification")
~~~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
