Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/13286#discussion_r64490957
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulAggregate.scala
---
@@ -82,40 +82,60 @@ case class StateStoreRestoreExec(
case class StateStoreSaveExec(
keyExpressions: Seq[Attribute],
stateId: Option[OperatorStateId],
+ returnAllStates: Boolean,
child: SparkPlan)
extends execution.UnaryExecNode with StatefulOperator {
override protected def doExecute(): RDD[InternalRow] = {
+ val saveAndReturnFunc = if (returnAllStates) saveAndReturnAll _ else
saveAndReturnUpdated _
child.execute().mapPartitionsWithStateStore(
getStateId.checkpointLocation,
operatorId = getStateId.operatorId,
storeVersion = getStateId.batchId,
keyExpressions.toStructType,
child.output.toStructType,
sqlContext.sessionState,
- Some(sqlContext.streams.stateStoreCoordinator)) { case (store, iter)
=>
- new Iterator[InternalRow] {
- private[this] val baseIterator = iter
- private[this] val getKey =
GenerateUnsafeProjection.generate(keyExpressions, child.output)
+ Some(sqlContext.streams.stateStoreCoordinator)
+ )(saveAndReturnFunc)
+ }
+
+ override def output: Seq[Attribute] = child.output
- override def hasNext: Boolean = {
- if (!baseIterator.hasNext) {
- store.commit()
- false
- } else {
- true
- }
- }
+ private def saveAndReturnUpdated(
+ store: StateStore,
+ iter: Iterator[InternalRow]): Iterator[InternalRow] = {
+ new Iterator[InternalRow] {
+ private[this] val baseIterator = iter
+ private[this] val getKey =
GenerateUnsafeProjection.generate(keyExpressions, child.output)
- override def next(): InternalRow = {
- val row = baseIterator.next().asInstanceOf[UnsafeRow]
- val key = getKey(row)
- store.put(key.copy(), row.copy())
- row
- }
+ override def hasNext: Boolean = {
+ if (!baseIterator.hasNext) {
+ store.commit()
+ false
+ } else {
+ true
}
+ }
+
+ override def next(): InternalRow = {
+ val row = baseIterator.next().asInstanceOf[UnsafeRow]
+ val key = getKey(row)
+ store.put(key.copy(), row.copy())
+ row
+ }
}
}
- override def output: Seq[Attribute] = child.output
+ private def saveAndReturnAll(
--- End diff --
nit: add docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
