Github user lgieron commented on a diff in the pull request:
https://github.com/apache/spark/pull/13264#discussion_r64545642
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala
---
@@ -59,7 +59,15 @@ class StorageListener(storageStatusListener:
StorageStatusListener) extends Bloc
override def onStageSubmitted(stageSubmitted:
SparkListenerStageSubmitted): Unit = synchronized {
val rddInfos = stageSubmitted.stageInfo.rddInfos
- rddInfos.foreach { info => _rddInfoMap.getOrElseUpdate(info.id, info) }
+ rddInfos.foreach { info =>
--- End diff --
OK I'm changing this. I'm not a fan of slower code in favor of brevity (as
my impression is that, over time, the entire code base just becomes slow and
fixing a couple bottlenecks won't necessarily help things), but it's the in the
general spirit of Scala (brevity over speed) so my one optimization would be
meaningless anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
