Github user gt-rocker commented on a diff in the pull request:
https://github.com/apache/spark/pull/10187#discussion_r64555557
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/OpenTsdbSink.scala ---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.util.Properties
+import java.util.concurrent.TimeUnit
+
+import com.codahale.metrics.MetricRegistry
+import com.github.sps.metrics.OpenTsdbReporter
+import com.github.sps.metrics.opentsdb.OpenTsdb
+import org.apache.spark.{Logging, SparkEnv}
+import org.apache.spark.metrics.MetricsSystem
+
+/**
+ * Created by kapil on 1/12/15.
+ */
+private[spark] class OpenTsdbSink(val property: Properties, val registry:
MetricRegistry,
+ securityMgr: SecurityManager) extends Sink with Logging
{
+ val OPENTSDB_DEFAULT_PERIOD = 10
+ val OPENTSDB_DEFAULT_UNIT = "SECONDS"
+ val OPENTSDB_DEFAULT_PREFIX = ""
+ val OPENTSDB_DEFAULT_TAG_NAME_1 = "appId"
+ val OPENTSDB_DEFAULT_TAG_VALUE_1 = SparkEnv.get.conf.getAppId
--- End diff --
I'm not a Spark comitter.
I took your code and made a separate jar. So I didn't patch Spark, I just
added my jar to classpath. It works great!
Please let me now if you have made other important code improvements :)
May be your code can live as a github repo?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
