Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221576056
@shivaram and @sun-rui I addressed the comment, added a test for this PR
and fixed some tests not working on Windows due to path separator.
This PR also fixes the test failures below.
- **Fixed case 1**
```
5. Failure: sparkJars sparkPackages as comma-separated strings
(@test_context.R#128)
6. Failure: sparkJars sparkPackages as comma-separated strings
(@test_context.R#131)
7. Failure: sparkJars sparkPackages as comma-separated strings
(@test_context.R#134)
```
The cases above were due to a weird behaviour of `normalizePath()`. On
Linux, if the path does not exist, it just prints out the input but it prints
out including the current path on Windows.
```r
# On Linus
path <- normalizePath("aa")
print(path)
[1] "aa"
# On Windows
path <- normalizePath("aa")
print(path)
[1] "C:\\Users\\aa"
```
- **Fixed case 2**
```
8. Failure: sparkJars tag in SparkContext (@test_includeJAR.R#34)
9. Failure: sparkJars tag in SparkContext (@test_includeJAR.R#36)
```
The cases above were due to using of `system2`.
Here is full stdout of my testing,
[output.msg](https://gist.github.com/HyukjinKwon/c72b747a15948bd062a26aba7c42115b)
on Windows.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
