Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/13269#discussion_r64617059
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala ---
@@ -42,17 +42,9 @@ class KeyValueGroupedDataset[K, V] private[sql](
private val dataAttributes: Seq[Attribute],
private val groupingAttributes: Seq[Attribute]) extends Serializable {
- // Similar to [[Dataset]], we use unresolved encoders for later
composition and resolved encoders
- // when constructing new logical plans that will operate on the output
of the current
- // queryexecution.
-
- private implicit val unresolvedKEncoder = encoderFor(kEncoder)
- private implicit val unresolvedVEncoder = encoderFor(vEncoder)
-
- private val resolvedKEncoder =
- unresolvedKEncoder.resolve(groupingAttributes, OuterScopes.outerScopes)
- private val resolvedVEncoder =
- unresolvedVEncoder.resolve(dataAttributes, OuterScopes.outerScopes)
+ // Similar to [[Dataset]], we turn the passed in encoder to
`ExpressionEncoder` explicitly.
+ private implicit val kEnc = encoderFor(kEncoder)
--- End diff --
Is it better to use the full name like keyEncoder?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
