Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/9192#discussion_r64633002
--- Diff: R/pkg/R/SQLContext.R ---
@@ -37,6 +37,37 @@ getInternalType <- function(x) {
stop(paste("Unsupported type for SparkDataFrame:", class(x))))
}
+#' Temporary function to reroute old S3 Method call to new
+#' We need to check the class of x to ensure it is SQLContext before
dispatching
+dispatchFunc <- function(newFuncSig, x, ...) {
--- End diff --
can we move this to utils.R. Also some function level comments on what the
arguments mean would be useful (for example `numFuncSig` is only used to print
the deprecation warning from what i see)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
