Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13304#discussion_r64660855
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala ---
@@ -38,12 +39,12 @@ abstract class OrcSuite extends QueryTest with
TestHiveSingleton with BeforeAndA
super.beforeAll()
orcTableAsDir = File.createTempFile("orctests", "sparksql")
- orcTableAsDir.delete()
+ Utils.deleteRecursively(orcTableAsDir)
--- End diff --
Use `Utils.createTempDir` rather than this which is hacky. It will be
automatically cleaned up too. We shouldn't have to reinvent this logic
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
