Github user xwu0226 commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221722759
@liancheng Thanks! I see what you mean for the code you handle the hive
compatible tables. This will handle the table lookup time.. But for [creating
table
](https://github.com/apache/spark/blob/193e0059be83006ddcce30a56c2b6ae09a2cac31/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala#L221-L248),
we still possibly wrongly set the `locationURI` with
`<warehouse.dir>/tableName/__PLACEHOLDER__` for hive-compatible table. such
that querying from Hive shell will not return any results, right?
This is one reason why I just wanted to tough the code path for creating
non-hive compatible datasource table in [createDataSourceTables.scala ->
CreateDataSourceTableUtils.createDataSourceTable](https://github.com/xwu0226/spark/blob/1c903d21e4e341b8e54f4a95c0c77e2b33c79297/sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala#L353-L379)
in my PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
