Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13302#discussion_r64667194
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
    @@ -288,9 +288,10 @@ case class TruncateTableCommand(
       override def run(sparkSession: SparkSession): Seq[Row] = {
         val catalog = sparkSession.sessionState.catalog
         if (!catalog.tableExists(tableName)) {
    -      logError(s"table '$tableName' in TRUNCATE TABLE does not exist.")
    +      throw new AnalysisException(s"Table '$tableName' in TRUNCATE TABLE 
does not exist.")
    --- End diff --
    
    For drop table with IF EXISTS keyword, it is unfortunate that Hive does not 
throw an exception when the table does not exist and changing it breaks lots of 
tests in HiveCompatibilitySuite.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to