Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/13308#discussion_r64774474
--- Diff: R/install-dev.sh ---
@@ -38,7 +38,12 @@ pushd $FWDIR > /dev/null
if [ ! -z "$R_HOME" ]
then
R_SCRIPT_PATH="$R_HOME/bin"
- else
+ else
+ # if system wide R_HOME is not found, then exit
+ if ! [ `command -v R` ]; then
--- End diff --
Yeah, we typically put the `!` after the test:
*
https://github.com/apache/spark/blob/6d506c9ae9a2519d1a93e788ae5316d4f942d35d/dev/lint-python#L44
*
https://github.com/apache/spark/blob/6d506c9ae9a2519d1a93e788ae5316d4f942d35d/dev/lint-java#L25
(In Bash, `[ ... ]` and `test` are synonyms.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
