Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13283#discussion_r64789688
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
    @@ -448,6 +448,14 @@ class Analyzer(
           }
         }
     
    +    /**
    +     * Data source formats that were not supported in direct query on file
    +     */
    +    private final val unsupportedFileQuerySource = Set(
    +      "org.apache.spark.sql.jdbc",
    --- End diff --
    
    Not sure about this. Looks hard to maintain. E.g., you forget to add 
`JdbcRelationProvider`. @rxin What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to