Github user yhuai commented on the pull request:

    https://github.com/apache/spark/pull/12313#issuecomment-221966605
  
    @rdblue Thank you for this PR. Those improvements sound good. I chatted 
with others. Here are two questions.
    1. `sqlContext.table("source").write.byName.insertInto("destination")` will 
change the behavior of insertInto and make it different from SQL's insertInto. 
Looks like it is better to have another command instead of changing the 
behavior of insertInto in this way.
    2. When we use resolution by name, seems we will complain if the data has 
less number of fields. What will happen if the data has more fields?
    
    How about we first improve the position-based resolution part? Then, we 
discuss the name-based part separately?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to