Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12972#discussion_r64838469
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala ---
@@ -451,4 +451,17 @@ class OrcQuerySuite extends QueryTest with
BeforeAndAfterAll with OrcTest {
}
}
}
+
+ test("SPARK-15198 Support for pushing down filters for boolean types") {
+ withSQLConf(SQLConf.ORC_FILTER_PUSHDOWN_ENABLED.key -> "true") {
+ val data = (0 until 10).map(_ => (true, false))
+ withOrcFile(data) { file =>
+ val actualTwo = spark.read.orc(file).where("_2 == true")
+
+ // ORC filter should be applied and the total count should be less
than
+ // the original data.
+ assert(stripSparkFilter(actualTwo).count() < data.length)
--- End diff --
If I understand this correctly, `.count()` here should be just zero?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
