Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64922718
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -212,11 +212,46 @@ class SessionCatalog(
* If no such database is specified, create it in the current database.
*/
def createTable(tableDefinition: CatalogTable, ignoreIfExists: Boolean):
Unit = {
- val db =
formatDatabaseName(tableDefinition.identifier.database.getOrElse(getCurrentDatabase))
- val table = formatTableName(tableDefinition.identifier.table)
+ val tableId = tableDefinition.identifier
+ val db =
formatDatabaseName(tableId.database.getOrElse(getCurrentDatabase))
+ val table = formatTableName(tableId.table)
val newTableDefinition = tableDefinition.copy(identifier =
TableIdentifier(table, Some(db)))
requireDbExists(db)
- externalCatalog.createTable(db, newTableDefinition, ignoreIfExists)
+
+ if (
+ // If this is an external data source table...
+ tableDefinition.properties.contains("spark.sql.sources.provider") &&
+ newTableDefinition.tableType == CatalogTableType.EXTERNAL &&
+ // ... that is not persisted as Hive compatible format (external
tables in Hive compatible
+ // format always set `locationUri` to the actual data location and
should NOT be hacked as
+ // following.)
+ tableDefinition.storage.locationUri.isEmpty
+ ) {
+ // !! HACK ALERT !!
+ //
+ // Due to a restriction of Hive metastore, here we have to set
`locationUri` to a temporary
+ // directory that doesn't exist yet but can definitely be
successfully created, and then
+ // delete it right after creating the external data source table.
This location will be
+ // persisted to Hive metastore as standard Hive table location URI,
but Spark SQL doesn't
+ // really use it. Also, since we only do this workaround for
external tables, deleting the
+ // directory after the fact doesn't do any harm.
+ //
+ // Please refer to https://issues.apache.org/jira/browse/SPARK-15269
for more details.
+
+ val tempPath =
+ new Path(defaultTablePath(tableId).stripSuffix(Path.SEPARATOR) +
"-__PLACEHOLDER__")
+
+ try {
+ externalCatalog.createTable(
+ db,
+ newTableDefinition.withNewStorage(locationUri =
Some(tempPath.toString)),
+ ignoreIfExists)
+ } finally {
+ FileSystem.get(tempPath.toUri, hadoopConf).delete(tempPath, true)
+ }
+ } else {
+ externalCatalog.createTable(db, newTableDefinition, ignoreIfExists)
+ }
--- End diff --
I think Hive-specific details/hacks should not be exposed in
`SessionCatalog`. Let's move it into `HiveExternalCatalog`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
