Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/13061#discussion_r64942108
--- Diff: project/SparkBuild.scala ---
@@ -436,7 +439,19 @@ object SparkBuild extends PomBuild {
else x.settings(Seq[Setting[_]](): _*)
} ++ Seq[Project](OldDeps.project)
}
+}
+object Core {
+ lazy val settings = Seq(
+ resourceGenerators in Compile += Def.task {
+ val buildScript = baseDirectory.value + "/../build/spark-build-info"
+ val targetDir = baseDirectory.value + "/target/extra-resources/"
+ val command = buildScript + " " + targetDir + " " + version.value
+ Process(command).!!
+ val propsFile = baseDirectory.value / "target" / "extra-resources" /
"spark-version-info.properties"
--- End diff --
Maybe a nit: shouldn't all resources be generated into `resourceManaged`?
I'm not sure how sbt will handle packaging of non-resourcemanaged artifacts; it
could be that spark works locally, however errors may occur in a packaged
environment.
I would suggest renaming `"target"/"extra-resources"` to `(resourceManaged
in Compile).value`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
