Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13363#discussion_r64974098 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala --- @@ -126,7 +126,14 @@ private[sql] case class AggregateExpression( AttributeSet(childReferences) } - override def toString: String = s"($aggregateFunction,mode=$mode,isDistinct=$isDistinct)" + override def toString: String = { + val agg = aggregateFunction + if (isDistinct) { + s"${mode}_${agg.prettyName}(distinct ${agg.argString(false)})" + } else { + s"${mode}_${agg.simpleString}" + } + } --- End diff -- Personally I'd prefer `:` instead of `_` as separator between `mode` and `agg`. Because `_` is a valid identifier character, while `:` is not, thus it's more obvious that `partial:` is a prefix rather part of the aggregate function name. (But that's pretty subjective.)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org