Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10896#discussion_r65103700 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -257,10 +257,19 @@ private[sql] abstract class SparkStrategies extends QueryPlanner[SparkPlan] { planLater(child)) } } else if (functionsWithDistinct.isEmpty) { + // Check if the child operator satisfies the group-by distribution requirements --- End diff -- Why not move this code block into `aggregate.Utils.planAggregateWithoutDistinct`?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org