Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13392#discussion_r65121902 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -17,13 +17,36 @@ package org.apache.spark.sql.internal +import org.scalatest.BeforeAndAfterAll + import org.apache.spark.sql.{QueryTest, Row, SparkSession, SQLContext} +import org.apache.spark.sql.execution.WholeStageCodegenExec import org.apache.spark.sql.test.{SharedSQLContext, TestSQLContext} -class SQLConfSuite extends QueryTest with SharedSQLContext { +class SQLConfSuite extends QueryTest with SharedSQLContext with BeforeAndAfterAll { --- End diff -- Initially, I tried it. The behavior is controlled by the configuration `SQLConf.MAX_CASES_BRANCHES`. However, I am not sure how to change the default conf value of `SQLConf.MAX_CASES_BRANCHES` in `OptimizeCodegenSuite`. At the same time, we do not have a test case to verify the configuration `MAX_CASES_BRANCHES`. That is why I added the test case here. Let me know if you have any idea. Thanks!
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org