Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12728#discussion_r65302512
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -114,13 +110,15 @@ case class InsertIntoHiveTable(
// Validate partition spec if there exist any dynamic partitions
if (numDynamicPartitions > 0) {
// Report error if dynamic partitioning is not enabled
- if (!hiveconf.getBoolVar(HiveConf.ConfVars.DYNAMICPARTITIONING)) {
+ if (!sessionState.conf.getConfString("hive.exec.dynamic.partition",
"true").toBoolean) {
--- End diff --
i think it is fine to enable dynamic partition insert by default. Seems it
is not necessary to create `spark.sql.dynamic.partition` since it is just an
alias of `hive.exec.dynamic.partition`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
